-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose boost query #250
Expose boost query #250
Conversation
The feature of default boost value could be more than essential for this library. Perhaps I can remove it if it is not desirable |
I agree - I think the boost value should always be supplied by the caller. FYI we do already have a higher-level boost mechanism here: tantivy-py/tests/tantivy_test.py Line 98 in deb88cc
It would be helpful to add to the docs a short example of when one would prefer to use the |
I have resolved the conflicts and updated the boost query not to have default value. There should be two more tests:
|
For the documentation, I am thinking should we add a new section under Currently we have a lot of implemented methods regarding the issue #20 and I think we should have a proper documentation for parameters accepted and usecases. |
yep agree 💯
Your suggestions lead me in the direction of:
What do you think? We can merge this PR first anyway, and do such docs in a different PR. |
Added BoostQuery class with tests.
Expected usage:
Test suite (✅ for expected success case, ❌ for expected failure case)